]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
usb: hub: Revise wLength for 'get port status' request
authorBin Meng <bmeng.cn@gmail.com>
Wed, 19 Jul 2017 13:49:59 +0000 (21:49 +0800)
committerMarek Vasut <marex@denx.de>
Fri, 28 Jul 2017 21:34:19 +0000 (23:34 +0200)
For accuracy, we should use 'sizeof(struct usb_port_status)' as the
wLength for 'get port status' request, although it happens to be
equal to 'sizeof(struct usb_hub_status)'.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Stefan Roese <sr@denx.de>
Tested-by: Stefan Roese <sr@denx.de>
common/usb_hub.c

index 48831b56814961fe32105d85402b1ce8fd7e45d8..83c6767a3b8413ca7ed9974309b5cefbf79ea89c 100644 (file)
@@ -107,7 +107,7 @@ int usb_get_port_status(struct usb_device *dev, int port, void *data)
 {
        return usb_control_msg(dev, usb_rcvctrlpipe(dev, 0),
                        USB_REQ_GET_STATUS, USB_DIR_IN | USB_RT_PORT, 0, port,
-                       data, sizeof(struct usb_hub_status), USB_CNTL_TIMEOUT);
+                       data, sizeof(struct usb_port_status), USB_CNTL_TIMEOUT);
 }