cmd: avoid endless loop in sound play command

A parameter starting with a hyphen leads to an endless loop in the sound
play command.

Leave it to dectoul() to handle the hyphen. It will return 0 for a negative
number.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

diff --git a/cmd/sound.c b/cmd/sound.c
index cef71be5e34ec15e4bf438c6df36c8a21035a99c..0b7f9599716b29a6d1f9d68fedaafe2caae648d4 100644 (file)
--- a/cmd/sound.c
+++ b/cmd/sound.c
@@ -48,12 +48,12 @@ static int do_play(struct cmd_tbl *cmdtp, int flag, int argc,
        ++argv;
        while (argc || first) {
                first = false;
-               if (argc && *argv[0] != '-') {
+               if (argc) {
                        msec = dectoul(argv[0], NULL);
                        --argc;
                        ++argv;
                }
-               if (argc && *argv[0] != '-') {
+               if (argc) {
                        freq = dectoul(argv[0], NULL);
                        --argc;
                        ++argv;