]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
regulator: bd718x7: Only bind children when PMIC_CHILDREN is enabled
authorAdam Ford <aford173@gmail.com>
Sat, 22 Oct 2022 13:43:42 +0000 (08:43 -0500)
committerStefano Babic <sbabic@denx.de>
Mon, 7 Nov 2022 21:45:04 +0000 (22:45 +0100)
If the bd718x7 is required, but PMIC_CHILDREN is disabled, this
driver throws a compile error.  Fix this by putting the function
to bind children into an if-statement checking for PMIC_CHILDREN.

Allowing PMIC_CHILDREN to be disabled in SPL saves some space and
still permits some read/write functions to access the PMIC in
early startup.

Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
drivers/power/pmic/bd71837.c

index cb9238972f2757054b8b9cce59215a59d9a1b4cf..fdbbd6f559382463a1550bd4c0539e18afa93192 100644 (file)
@@ -63,10 +63,11 @@ static int bd71837_bind(struct udevice *dev)
 
        debug("%s: '%s' - found regulators subnode\n", __func__, dev->name);
 
-       children = pmic_bind_children(dev, regulators_node, pmic_children_info);
-       if (!children)
-               debug("%s: %s - no child found\n", __func__, dev->name);
-
+       if (CONFIG_IS_ENABLED(PMIC_CHILDREN)) {
+               children = pmic_bind_children(dev, regulators_node, pmic_children_info);
+               if (!children)
+                       debug("%s: %s - no child found\n", __func__, dev->name);
+       }
        /* Always return success for this device */
        return 0;
 }