]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
serial: ns16550: Handle zero <clock-frequency> value
authorBin Meng <bmeng.cn@gmail.com>
Wed, 3 Feb 2021 14:42:25 +0000 (22:42 +0800)
committerSimon Glass <sjg@chromium.org>
Thu, 4 Mar 2021 02:17:25 +0000 (19:17 -0700)
A working device tree node of ns16550 should never be populated
with value zero for the <clock-frequency> property. Unfortunately
this is the case for the QEMU ppce500 target.

Let's try to assign plat->clock to CONFIG_SYS_NS16550_CLK as the
last resort to handle such case.

This commit should be reverted when:

- The following QEMU patch [1] is merged, and
- U-Boot CI has upgraded its QEMU version that contains the fix

[1] http://patchwork.ozlabs.org/project/qemu-devel/patch/1612362288-22216-2-git-send-email-bmeng.cn@gmail.com/

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
drivers/serial/ns16550.c

index 1377c9a0e11dc3c0a7f25e7389e3ba0135fbf7d5..cc121eee277d8696c800542f6b9f8592fcb55323 100644 (file)
@@ -564,6 +564,8 @@ int ns16550_serial_of_to_plat(struct udevice *dev)
        if (!plat->clock)
                plat->clock = dev_read_u32_default(dev, "clock-frequency",
                                                   CONFIG_SYS_NS16550_CLK);
+       if (!plat->clock)
+               plat->clock = CONFIG_SYS_NS16550_CLK;
        if (!plat->clock) {
                debug("ns16550 clock not defined\n");
                return -EINVAL;