]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
toradex: Fix recursive call to checkboard
authorEmanuele Ghidoli <emanuele.ghidoli@toradex.com>
Fri, 23 Feb 2024 09:11:37 +0000 (10:11 +0100)
committerTom Rini <trini@konsulko.com>
Fri, 1 Mar 2024 14:10:44 +0000 (09:10 -0500)
Since checkboard() is used instead of show_board_info(), in case toradex
config block is missing or malformed, checkboard is recursively called.
It prints a long list of "MISSING TORADEX CONFIG BLOCK" till the stack
is full.

Fixes: edb0ecd18708 ("toradex: Use checkboard() instead of show_board_info()")
Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> # Verdin iMX8M Plus
Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
board/toradex/common/tdx-common.c

index ed8f0a6a4756e0e2f0b477efa6d8fcefd4264a83..ddc4a175da68ccac84e250deaaac1b4450064d2a 100644 (file)
@@ -103,7 +103,6 @@ int tdx_checkboard(void)
        if (read_tdx_cfg_block()) {
                printf("MISSING TORADEX CONFIG BLOCK\n");
                get_mac_from_serial(tdx_serial, &tdx_eth_addr);
-               checkboard();
        } else {
                snprintf(tdx_serial_str, sizeof(tdx_serial_str),
                         "%08u", tdx_serial);