]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
net: gem: Reduce timeout of mdio phy idle status check
authorAshok Reddy Soma <ashok.reddy.soma@xilinx.com>
Thu, 18 Nov 2021 12:05:24 +0000 (13:05 +0100)
committerMichal Simek <michal.simek@xilinx.com>
Wed, 5 Jan 2022 10:16:21 +0000 (11:16 +0100)
Timeout for checking mdio phy idle status is 20seconds. In case of errors
this timeout will be too much. Reduce it to 100ms.

Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Link: https://lore.kernel.org/r/1b73aa57b77587391e1bcd6d9f0480163367ed1b.1637237121.git.michal.simek@xilinx.com
drivers/net/zynq_gem.c

index 336d569b37400d9bff9009e2fe9208ed4991e2dd..b751d28e611f305b0be1ce47a2d1c9bf6cbd53ab 100644 (file)
 
 #define ZYNQ_GEM_DCFG_DBG6_DMA_64B     BIT(23)
 
+#define MDIO_IDLE_TIMEOUT_MS           100
+
 /* Use MII register 1 (MII status register) to detect PHY */
 #define PHY_DETECT_REG  1
 
@@ -228,7 +230,7 @@ static int phy_setup_op(struct zynq_gem_priv *priv, u32 phy_addr, u32 regnum,
        int err;
 
        err = wait_for_bit_le32(&regs->nwsr, ZYNQ_GEM_NWSR_MDIOIDLE_MASK,
-                               true, 20000, false);
+                               true, MDIO_IDLE_TIMEOUT_MS, false);
        if (err)
                return err;
 
@@ -241,7 +243,7 @@ static int phy_setup_op(struct zynq_gem_priv *priv, u32 phy_addr, u32 regnum,
        writel(mgtcr, &regs->phymntnc);
 
        err = wait_for_bit_le32(&regs->nwsr, ZYNQ_GEM_NWSR_MDIOIDLE_MASK,
-                               true, 20000, false);
+                               true, MDIO_IDLE_TIMEOUT_MS, false);
        if (err)
                return err;