lib: libfdt: fdt_region: avoid NULL pointer access

The function fdt_find_regions look in the exclude list for each
property, even if the name is NULL. It could happen if the fit
image is corrupted. On sandbox, it generates a segfault.

To avoid this issue, if the name of a property is NULL, we report
an error and avoid looking in the exclude list.

Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

diff --git a/common/fdt_region.c b/common/fdt_region.c
index 667659054a7e6c9cd86aeb57028e38a9149e3e58..ff12c518e97a605e6178a935de33f42e90740b91 100644 (file)
--- a/common/fdt_region.c
+++ b/common/fdt_region.c
@@ -65,6 +65,8 @@ int fdt_find_regions(const void *fdt, char * const inc[], int inc_count,
                        stop_at = offset;
                        prop = fdt_get_property_by_offset(fdt, offset, NULL);
                        str = fdt_string(fdt, fdt32_to_cpu(prop->nameoff));
+                       if (!str)
+                               return -FDT_ERR_BADSTRUCTURE;
                        if (str_in_list(str, exc_prop, exc_prop_count))
                                include = 0;
                        break;