]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
board: ten64: add missing error checks for retimer power on
authorMathew McBride <matt@traverse.com.au>
Mon, 7 Aug 2023 01:41:08 +0000 (01:41 +0000)
committerTom Rini <trini@konsulko.com>
Mon, 7 Aug 2023 17:41:44 +0000 (13:41 -0400)
The retimer reset/power on logic was changed in a recent commit,
however, it neglected to check if the commands sent to the
board microcontroller (to control power to the retimer chip)
actually completed.

Add return checks for these operations so any failures will
be reported to the user.

Signed-off-by: Mathew McBride <matt@traverse.com.au>
Fixes: 7a041fea2 ("board: traverse: ten64: ensure retimer reset
is done on new board revisions")

board/traverse/ten64/ten64.c

index 52daae6e24dbe1bd98933f5cdc704f05f142cd42..df9f0afe1a4f78010c91326e4f173ee7021e597d 100644 (file)
@@ -383,10 +383,15 @@ static int board_cycle_retimer(struct udevice **retim_dev)
                        puts("(retimer on, resetting...) ");
 
                        ret = misc_call(uc_dev, TEN64_CNTRL_10G_OFF, NULL, 0, NULL, 0);
+                       if (ret)
+                               return ret;
                        mdelay(1000);
                }
 
+               /* Turn on the retimer */
                ret = misc_call(uc_dev, TEN64_CNTRL_10G_ON, NULL, 0, NULL, 0);
+               if (ret)
+                       return ret;
        }
 
        // Wait for retimer to come back