]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
bootstd: Fix listing boot devices
authorMichal Suchanek <msuchanek@suse.de>
Wed, 12 Oct 2022 19:57:53 +0000 (21:57 +0200)
committerSimon Glass <sjg@chromium.org>
Tue, 18 Oct 2022 03:17:12 +0000 (21:17 -0600)
bootdev_list() uses uclass_*_device_err() to iterate devices.
However, the only value _err adds is returning an error when the device
pointer is null, and that's checked anyway.

Also there is some intent to report errors, and that's what
uclass_*_device_check() is for, use it.

Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
boot/bootdev-uclass.c

index 13ac69eb392fd70822e4ddbbeafe472858d2b761..9d98bee454919ee1e147b29818424f36c002bae4 100644 (file)
@@ -195,7 +195,7 @@ void bootdev_list(bool probe)
        printf("Seq  Probed  Status  Uclass    Name\n");
        printf("---  ------  ------  --------  ------------------\n");
        if (probe)
-               ret = uclass_first_device_err(UCLASS_BOOTDEV, &dev);
+               ret = uclass_first_device_check(UCLASS_BOOTDEV, &dev);
        else
                ret = uclass_find_first_device(UCLASS_BOOTDEV, &dev);
        for (i = 0; dev; i++) {
@@ -204,7 +204,7 @@ void bootdev_list(bool probe)
                       ret ? simple_itoa(ret) : "OK",
                       dev_get_uclass_name(dev_get_parent(dev)), dev->name);
                if (probe)
-                       ret = uclass_next_device_err(&dev);
+                       ret = uclass_next_device_check(&dev);
                else
                        ret = uclass_find_next_device(&dev);
        }