]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
patman: Issue empty change logs for unchanged patches
authorSimon Glass <sjg@chromium.org>
Tue, 30 Oct 2012 06:15:16 +0000 (06:15 +0000)
committerAnatolij Gustschin <agust@denx.de>
Wed, 14 Nov 2012 09:22:47 +0000 (10:22 +0100)
Often a particular patch may change only for some versions of a series.
For versions where there is no change, issue a change log indicating
that (for example 'Changes in v4: None').

For such lines, don't add a blank line afterwards, to conserve space.
Use list.insert() instead of list = [item] + list.

Signed-off-by: Simon Glass <sjg@chromium.org>
Tested-by: Stefan Roese <sr@denx.de>
tools/patman/series.py

index a283a2d1f4b2e0bdbb519f58c3a5af9bb87fb0e5..d2971f48983afe05f259be47284360442cbac552 100644 (file)
@@ -145,10 +145,11 @@ class Series(dict):
         Return:
             The change log as a list of strings, one per line
 
-            Changes in v2:
+            Changes in v4:
             - Jog the dial back closer to the widget
 
-            Changes in v1:
+            Changes in v3: None
+            Changes in v2:
             - Fix the widget
             - Jog the dial
 
@@ -162,12 +163,16 @@ class Series(dict):
                 if commit and this_commit != commit:
                     continue
                 out.append(text)
-            if out:
-                out = ['Changes in v%d:' % change] + out
-                if need_blank:
-                    out = [''] + out
-                final += out
-                need_blank = True
+            line = 'Changes in v%d:' % change
+            have_changes = len(out) > 0
+            if have_changes:
+                out.insert(0, line)
+            else:
+                out = [line + ' None']
+            if need_blank:
+                out.insert(0, '')
+            final += out
+            need_blank = have_changes
         if self.changes:
             final.append('')
         return final