]> git.dujemihanovic.xyz Git - u-boot.git/commit
GPT: incomplete initialization in allocate_disk_part
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Thu, 21 Sep 2017 17:03:06 +0000 (19:03 +0200)
committerTom Rini <trini@konsulko.com>
Tue, 26 Sep 2017 16:54:42 +0000 (12:54 -0400)
commitf66bc0e0beeff7fa27c29f740d2f314d63b3346d
tree9813ee27e35620879f4dda259abded7818c87e47
parent0cc8c3064d4be2f5492f04f9d1eda1ee256ac4e7
GPT: incomplete initialization in allocate_disk_part

memset(newpart, '\0', sizeof(newpart));
only initializes the firest 4 or 8 bytes of *newpart and not the whole
structure disk_part.

We should use sizeof(struct disk_part).

Instead of malloc and memset we can use calloc.

Identified by cppcheck.

Fixes: 09a49930e41 GPT: read partition table from device into a data structure
Reported-by: Coverity (CID: 167228)
Cc: Stefan Roese <sr@denx.de>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
cmd/gpt.c