]> git.dujemihanovic.xyz Git - u-boot.git/commit
phy: rockchip: snps-pcie3: Fix bifurcation for RK3588
authorSebastian Kropatsch <seb-dev@mail.de>
Sun, 14 Jul 2024 21:23:42 +0000 (23:23 +0200)
committerKever Yang <kever.yang@rock-chips.com>
Wed, 17 Jul 2024 06:48:18 +0000 (14:48 +0800)
commitee84a18b3d7fd5aca41f06765fe8027519b2e176
tree491f54ba61eb4def13fe45b5cecda079d5746d88
parentb962b490b74ff195daa7fbc030bc8ed60ebc082b
phy: rockchip: snps-pcie3: Fix bifurcation for RK3588

Misconfigured `PHP_GRF_PCIESEL` values are causing bifurcation issues,
for example on the FriendlyElec CM3588 NAS board which uses bifurcation
on both PCIe PCIe ports (all four lanes) to enable four M.2 NVMe
sockets. Without this fix, NVMe devices do not get recognized.

Correct the `PHP_GRF_PCIESEL` register configuration and simplify the
bifurcation logic, enabling proper PCIe bifurcation based on the
data-lanes property.

This fix is adapted from the upstream Linux commit by Michal Tomek:
f8020dfb311d ("phy: rockchip-snps-pcie3: fix bifurcation on rk3588")

Fixes: 50e54e80679b ("phy: rockchip: snps-pcie3: Add support for RK3588")
Signed-off-by: Sebastian Kropatsch <seb-dev@mail.de>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
drivers/phy/rockchip/phy-rockchip-snps-pcie3.c