]> git.dujemihanovic.xyz Git - u-boot.git/commit
mmc: Fix incorrect handling of 'read' & 'write' commands
authorTaylor Hutt <thutt@chromium.org>
Thu, 22 Nov 2012 09:13:00 +0000 (09:13 +0000)
committerAndy Fleming <afleming@freescale.com>
Tue, 27 Nov 2012 23:26:49 +0000 (17:26 -0600)
commited80c931ba7781e6605b9bdaa2a0d58ef365fe71
tree7a53d7cc2d493b2e7bad57a88b764892d64e9eb7
parent1981539914b3626efe4a97bde19ec5fe548b50cf
mmc: Fix incorrect handling of 'read' & 'write' commands

If a malformed 'read' or 'write' command is issued, the Sandbox U-Boot
can crash because the command-handling code does no error checking on
the number of provided arguments.

This change makes the mmc 'erase', 'read' and 'write' commands only
function if the proper number of arguments are supplied.

Also puts the else assignment at the beginning fo the if() statement
to shortens the generated code.  This removes an unnecessary jump from
the generated code.

Signed-off-by: Taylor Hutt <thutt@chromium.org>
Signed-off-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Andy Fleming <afleming@freescale.com>
common/cmd_mmc.c