]> git.dujemihanovic.xyz Git - u-boot.git/commit
fdt: fix 'prop (...) not found!' error in 'fdt set' command
authorHannes Schmelzer <oe5hpm@oevsv.at>
Fri, 18 Aug 2017 12:41:14 +0000 (14:41 +0200)
committerSimon Glass <sjg@chromium.org>
Mon, 4 Sep 2017 08:10:06 +0000 (02:10 -0600)
commitcee8c35d1b7101d09a1854a48f867deaa701f7bf
tree96fb5e9b82fb4b60d63027f65cb5919301ff9fcb
parent302466d07fe8f10ff2ad059dc5c40ac37935fda9
fdt: fix 'prop (...) not found!' error in 'fdt set' command

This commit brings things back to the well known working state of the
command.
-
With commit 9620d87259572ef21f0df60988d9a932ca673779
(cmd/fdt: support single value replacement within an array)

there was an error introduced modifying (inserting) a property to a
device-tree node.
fdt_getprop(...) returnes a len with -1 for a non-existing property, but
a memcpy with len -1 isn't a good idea and things went wrong (crash).
-
Some times later Tom did repair this
with commit 99bb38e2cce9d99238458e0f6d1880c6d2e80a4d
(fdt: Check for NULL return from fdt_getprop in 'fdt set')

This repairs the crash but the behaviour of the command isn't like
before, it makes it impossible to insert a property.
-

Signed-off-by: Hannes Schmelzer <oe5hpm@oevsv.at>
Acked-by: Simon Glass <sjg@chromium.org>
cmd/fdt.c