]> git.dujemihanovic.xyz Git - u-boot.git/commit
usb: gadget: cdns3: Fix cdns3_ep_config() by setting ep.maxpacket
authorSiddharth Vadapalli <s-vadapalli@ti.com>
Mon, 7 Oct 2024 12:19:27 +0000 (17:49 +0530)
committerMattijs Korpershoek <mkorpershoek@baylibre.com>
Fri, 11 Oct 2024 12:32:38 +0000 (14:32 +0200)
commitc54c72dec7948093b200ae1290575a1e9abbbb40
treeb92ae3ed74cc64c08d855fd9fdb9bb7cbce0c196
parentce1023de730ffa37beae46a5276061a74a041a09
usb: gadget: cdns3: Fix cdns3_ep_config() by setting ep.maxpacket

The function cdns3_ep_config() calculates the maximum packet size based
on the Endpoint Type and the Gadget Speed and stores it in the variable
"max_packet_size". This value is then programmed in the USB Controller
for the corresponding Endpoint. This may result in a mismatch between
the maximum packet size programmed in the USB controller and the maximum
packet size seen by the UDC Core via "maxpacket" member of "struct usb_ep".
Additionally, since TD_SIZE is calculated in cdns3_ep_run_transfer() on the
basis of the maximum packet size stored in the "maxpacket" member of
"struct usb_ep", it may lead to an incorrect value of TD_SIZE when compared
with what the USB controller actually expects (max_packet_size).

Fix this.

Fixes: 7e91f6ccdc84 ("usb: Add Cadence USB3 host and gadget driver")
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Link: https://lore.kernel.org/r/20241007121927.1680039-1-s-vadapalli@ti.com
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
drivers/usb/cdns3/gadget.c