]> git.dujemihanovic.xyz Git - u-boot.git/commit
efi_loader: loosen buffer parameter check in efi_file_read_int
authorPeng Fan <peng.fan@nxp.com>
Wed, 28 Apr 2021 13:54:01 +0000 (21:54 +0800)
committerHeinrich Schuchardt <xypron.glpk@gmx.de>
Tue, 18 May 2021 10:36:12 +0000 (12:36 +0200)
commitbc3f46518176e541c767b099fb06ad1870d59fa5
tree3512e762fa8928c66c490f24bc1ddcba0ac9531e
parent6a2e26b95f046a2973a95119910cbe2554c92b46
efi_loader: loosen buffer parameter check in efi_file_read_int

This is same issue as https://bugzilla.redhat.com/show_bug.cgi?id=1733817,
but that fix was wrongly partial reverted.

When reading a directory, EFI_BUFFER_TOO_SMALL should be returned when
the supplied buffer is too small, so a use-case is to call
EFI_FILE_PROTOCOL.Read() with *buffer_size=0 and buffer=NULL to
obtain the needed size before doing the actual read.

So remove the check only for directory reading, file reading already
do the check by itself.

Fixes: db12f518edb0("efi_loader: implement non-blocking file services")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Stefan Sørensen <stefan.sorensen@spectralink.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
lib/efi_loader/efi_file.c