]> git.dujemihanovic.xyz Git - u-boot.git/commit
u_boot_pylib: Ensure subprocess is closed down
authorSimon Glass <sjg@chromium.org>
Wed, 1 Nov 2023 17:17:50 +0000 (11:17 -0600)
committerTom Rini <trini@konsulko.com>
Fri, 3 Nov 2023 02:38:01 +0000 (22:38 -0400)
commitae94c3d4ee21ba4dd628d2f463fb3992233963ef
tree7903a15c182f0e119e7e4abaa0f7d4a01c1001b9
parenta44cb1f2402a7f20f68e245bd37d6bdfe34e70f2
u_boot_pylib: Ensure subprocess is closed down

It isn't clear why we need to have two different paths for closing down
the pipe. Unify them and use the Python to avoid this warning:

  subprocess.py:1127: ResourceWarning: subprocess 83531 is still running

Note that this code appears to originally have come from [1] and was
committed into the ChromeOS chromiumos/platform/crosutils repo in the
bin/cros_image_to_target.py file. The addition of the extra code path
came later, so that is chosen for the fixes tag.

[1] https://codereview.chromium.org/3391008

Signed-off-by: Simon Glass <sjg@chromium.org>
Fixes: a10fd93cbc patman: Make command methods return a CommandResult
tools/u_boot_pylib/command.py