]> git.dujemihanovic.xyz Git - u-boot.git/commit
spl: fit: Factor out FIT parsing and use a context struct
authorAlexandru Gagniuc <mr.nuke.me@gmail.com>
Wed, 20 Jan 2021 16:46:50 +0000 (10:46 -0600)
committerTom Rini <trini@konsulko.com>
Wed, 17 Feb 2021 22:12:45 +0000 (17:12 -0500)
commit917fa369f6fbdc2011e500fbeea0e07ba70af9c3
treedd2eee300e2fb0c6bb8ef237135cbea4f76cab21
parentefc4ad0bc763f135f3437f51df693e83941a9928
spl: fit: Factor out FIT parsing and use a context struct

The logical steps in spl_load_simple_fit() are difficult to follow.
I think the long comments, ifdefs, and ungodly number of variables
seriously affect the readability. In particular, it violates section 6
of the coding style, paragraphs (3), and (4).

The purpose of this patch is to improve the situation by
  - Factoring out initialization and parsing to separate functions
  - Reduce the number of variables by using a context structure
This change introduces no functional changes.

Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
common/spl/spl_fit.c