]> git.dujemihanovic.xyz Git - u-boot.git/commit
efi_loader: capsule: fix SIZEOF_MISMATCH warning
authorAKASHI Takahiro <takahiro.akashi@linaro.org>
Fri, 22 Jan 2021 01:43:27 +0000 (10:43 +0900)
committerHeinrich Schuchardt <xypron.glpk@gmx.de>
Sat, 23 Jan 2021 06:56:53 +0000 (07:56 +0100)
commit8f1844c3335be8bcf22de63057cf8f0c11416d00
treec1b23c0a6b657afed2e74603aa7c9f89f04154c8
parent30f8222bb0016eef29afdd997bd1b3cdc486fdf9
efi_loader: capsule: fix SIZEOF_MISMATCH warning

CID 316361 says:
> Passing argument "count * 8UL /* sizeof (*files) */" to
> function "dlmalloc" and then casting the return value to "u16 **" is
> suspicious. In this particular case "sizeof (u16 **)" happens to be equal
> to "sizeof (u16 *)", but this is not a portable assumption.
> > 767         tmp_files = malloc(count * sizeof(*files));

The change in this patch fixes the ambiguity.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Fixes: CID 316361
For readability use *tmp_files instead of tmp_files[0]
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
lib/efi_loader/efi_capsule.c