]> git.dujemihanovic.xyz Git - u-boot.git/commit
cbfs: do not pack struct cbfs_cachenode
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Sun, 6 Oct 2019 22:37:45 +0000 (00:37 +0200)
committerBin Meng <bmeng.cn@gmail.com>
Sat, 2 Nov 2019 10:00:51 +0000 (18:00 +0800)
commit895ae8726dea182c8512fc6154bd0f9a6a06657b
tree5bc5ee762d6f3543d0470e7e0225f980bf4556bc
parent5d6f05352b69d4858a2a9e9136ac3a734f0222bb
cbfs: do not pack struct cbfs_cachenode

With the __packed attribute sandbox_defconfig cannot be compiled with GCC
9.2.1:

fs/cbfs/cbfs.c: In function ‘file_cbfs_fill_cache’:
fs/cbfs/cbfs.c:164:16: error: taking address of packed member of
‘struct cbfs_cachenode’ may result in an unaligned pointer value
[-Werror=address-of-packed-member]
  164 |   cache_tail = &new_node->next;
      |                ^~~~~~~~~~~~~~~

struct cbfs_cachenode is only an internal structure. So let's rearrange the
fields such that the structure is naturally packed and remove the __packed
attribute.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
include/cbfs.h