]> git.dujemihanovic.xyz Git - u-boot.git/commit
sata: ahsata: Fix wrong operand for checking SERR DIAG_X
authorYe Li <ye.li@nxp.com>
Sun, 3 May 2020 14:27:01 +0000 (22:27 +0800)
committerTom Rini <trini@konsulko.com>
Fri, 8 May 2020 22:29:03 +0000 (18:29 -0400)
commit87e2cb530fc147676319b7c639e7ce138ddf385e
tree1ba18b7de8ffb92a89e0dc8dcc58eaa8b35f795b
parentbf38cbf9a289c41a0db6697c280ede73340191e7
sata: ahsata: Fix wrong operand for checking SERR DIAG_X

Fix coverity issue CID 3261683: Wrong operator used
(CONSTANT_EXPRESSION_RESULT) operator_confusion:
({...; __v;}) | 67108864 is always 1/true regardless of the values
of its operand. This occurs as the logical operand of !

When DIAG_X is set, the PHY COMINIT signal is detected, so
should use '&' to check whether it is set.

Signed-off-by: Ye Li <ye.li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
drivers/ata/dwc_ahsata.c