]> git.dujemihanovic.xyz Git - u-boot.git/commit
dm: update test on of_offset in ofnode_valid
authorPatrick Delaunay <patrick.delaunay@st.com>
Thu, 24 Sep 2020 15:26:20 +0000 (17:26 +0200)
committerSimon Glass <sjg@chromium.org>
Tue, 6 Oct 2020 15:07:54 +0000 (09:07 -0600)
commit6d9949fe866751c527c5dafab5350af89b7b8332
tree51b073975092d29df11ff9b60bf2bf9b5c244fc0
parent45dbe75da6fbc3de280021bf4b5c9dfc94c70f8f
dm: update test on of_offset in ofnode_valid

Update the test for node.of_offset because an invalid offset is not
always set to -1 because the return value of the libfdt functions are:
+ an error with a value < 0
+ a valid offset with value >=0

For example, in ofnode_get_by_phandle() function, we have:
node.of_offset = fdt_node_offset_by_phandle(gd->fdt_blob, phandle);
and this function can return -FDT_ERR_BADPHANDLE (-6).

Without this patch, the added test dm_test_ofnode_get_by_phandle failed.

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
include/dm/ofnode.h
test/dm/ofnode.c