]> git.dujemihanovic.xyz Git - u-boot.git/commit
i2c: microchip: fix erroneous late ack send
authorConor Dooley <conor.dooley@microchip.com>
Wed, 26 Oct 2022 07:49:19 +0000 (08:49 +0100)
committerHeiko Schocher <hs@denx.de>
Mon, 14 Nov 2022 06:21:58 +0000 (07:21 +0100)
commit6d133b31580a90e24fe95292a3e55aabe0fcc2da
tree6ec8a6862d2a669dfd7f66dc9f889c042c75d261
parent95b22bd6dcf198340b0c40a906a463064c215b0c
i2c: microchip: fix erroneous late ack send

A late ack is currently being sent at the end of a transfer due to
incorrect logic in mchp_corei2c_empty_rx(). Currently the Assert Ack
bit is being written to the controller's control reg after the last
byte has been received, causing it to sent another byte with the ack.
Instead, the AA flag should be written to the control register when
the penultimate byte is read so it is sent out for the last byte.

Reported-by: Andreas Buerkler <andreas.buerkler@enclustra.com>
Fixes: 0dc0d1e094 ("i2c: Add Microchip PolarFire SoC I2C driver")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Padmarao Begari <padmarao.begari@microchip.com>
Reviewed-by: Heiko Schocher <hs@denx.de>
Removed Tag by hs: Fixes: 0190d48488 ("i2c: microchip: fix ack sending logic")
drivers/i2c/i2c-microchip.c