]> git.dujemihanovic.xyz Git - u-boot.git/commit
virtio_blk: set log2blksz correctly
authorAKASHI Takahiro <takahiro.akashi@linaro.org>
Wed, 19 Aug 2020 09:07:32 +0000 (18:07 +0900)
committerTom Rini <trini@konsulko.com>
Mon, 24 Aug 2020 18:11:31 +0000 (14:11 -0400)
commit6b0ddd1fbc6c8f7cbd0418e8a87d02404ad3dd9b
tree3665c3ed50e091314f49216994a5d852a59bb924
parent91f6c1ca2e4400f30b5faee04f1dd9001abd326f
virtio_blk: set log2blksz correctly

'log2blksz' in blk_desc structure must always be initialized, otherwise
it will cause a lot of weird failures in file operations.

For example, fs_set_blk_dev[_with_part]() examines a block device against
every file system with its probe function. In particular, ext4 file
system's ext4_probe() will calls fs_devread() to fetch a super block.
If log2blksz is 0, the actual 'read' size, i.e. block_len >> log2blksz, is
much bigger than a buffer's size, and it can end up with memory corruption.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Fixes: f4802209e59d ("virtio: Add block driver support")
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
drivers/virtio/virtio_blk.c