]> git.dujemihanovic.xyz Git - u-boot.git/commit
pinctrl: stmfx: Fix pin configuration issue
authorPatrice Chotard <patrice.chotard@foss.st.com>
Wed, 20 Jan 2021 12:43:39 +0000 (13:43 +0100)
committerPatrick Delaunay <patrick.delaunay@foss.st.com>
Tue, 9 Feb 2021 09:25:31 +0000 (10:25 +0100)
commit54f5bf3d61084c15a9e364ac7a5fdede7c1c780e
tree77afaf81510483cf9ff142cb58e9642abd11b1ae
parent8c005c731f155e73b742ec6a4de1ba7e0b1a8bf9
pinctrl: stmfx: Fix pin configuration issue

pin-controller pin's name must be equal to pin's name used in device
tree with "pins" DT property.

Issue detected on stm32mp157c-ev1 board with goodix touchscreen.
In DT, the goodix's pin is declared in DT with the node:

        goodix_pins: goodix {
pins = "gpio14";
bias-pull-down;
};

Whereas in stmfx pin-controller driver, pin's name are equal to
"stmfx_gpioxx" where xx is the pin number.
This lead to not configure stmfx's pins at probe because pins is
identified by its name (see pinctrl_pin_name_to_selector() in
pinctrl-generic.c) and stmfx pin "gpio14" can't be found.

To fix this issue, come back to the original stmfx pin's name.

Revert "pinctrl: stmfx: update pin name"

This reverts commit 38d30cdcd65c73eeefac5efa328ad444a53b77dd.

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
Tested-by: Patrick DELAUNAY <patrick.delaunay@st.com>
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
drivers/pinctrl/pinctrl-stmfx.c