]> git.dujemihanovic.xyz Git - u-boot.git/commit
Revert "sunxi: psci: avoid error address-of-packed-member"
authorTomasz Duszynski <tduszyns@gmail.com>
Sun, 16 Feb 2020 12:17:16 +0000 (13:17 +0100)
committerJagan Teki <jagan@amarulasolutions.com>
Wed, 18 Mar 2020 10:07:08 +0000 (15:37 +0530)
commit3586cb82277e8af9eae38b354bb8b2aee38ee377
tree44ad14f38595fe7528584ac4fa5c31fa9934a5c1
parenta4df9d8ab848ea4ff10b247ae435b0a14bbbd066
Revert "sunxi: psci: avoid error address-of-packed-member"

Using memcpy() for some MMIO access is generally frowned upon and might
break things on some platforms. Allwinner H3, which fails to boot, being
an example here.

Moreover, fields being accessed are naturally aligned and warnings
produced by GCC have been quiesced for some time already by:

53dc8ae ("gcc-9: silence 'address-of-packed-member' warning")

That said, it should be okay to revert this commit.

This reverts commit 9bd34a69a453d409792e08c00953ce8862145e65.

Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
Acked-by: Jagan Teki <jagan@amarulasolutions.com>
arch/arm/cpu/armv7/sunxi/psci.c