]> git.dujemihanovic.xyz Git - u-boot.git/commit
net: zynq_gem: Fix masking of supported phydev features
authorNathan Rossi <nathan@nathanrossi.com>
Sun, 5 Mar 2017 14:36:23 +0000 (00:36 +1000)
committerJoe Hershberger <joe.hershberger@ni.com>
Tue, 7 Mar 2017 17:27:33 +0000 (11:27 -0600)
commit2c2ab8d65ff6c95a8af0fdb90cb34a777c28e3a1
tree897d2859f01882a57c94db1286c864e33f31da38
parent3fd2b3aa19b9479b5e785087e4951d3a7bbb87be
net: zynq_gem: Fix masking of supported phydev features

When the zynq_gem driver initializes the phy it sets the supported
features that the phy can support and advertise. However instead of
masking the supported features such that it limits the available
features it sets the phy to have the exact supported features of the
zynq_gem. This is problematic as it will enable features that a phy does
not have or cannot advertise.

Specifically this appears as an issue when using a phy that is only
capable of 10/100, but the zynq_gem driver will override this and try to
enable and advertise 10/100/1000.

Reported-by: Arno Steffens <star@gmx.li>
Fixes: 80243528ef ("net: gem: Fix gem driver on 1Gbps LAN")
Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Tested-by: Arno Steffens <star@gmx.li>
Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
drivers/net/zynq_gem.c