]> git.dujemihanovic.xyz Git - u-boot.git/commit
common: command: Handle USAGE failure separately
authorMichal Simek <michal.simek@xilinx.com>
Thu, 21 Jun 2018 12:49:26 +0000 (14:49 +0200)
committerMichal Simek <michal.simek@xilinx.com>
Thu, 19 Jul 2018 08:49:53 +0000 (10:49 +0200)
commit27eb7bce3943111dd70c19569b60d9a047f06811
treea8a4cd2bbce7c294c515088f255f6a4ee82432a4
parent3723324042ec92739d802604558a3ebe3d5616dc
common: command: Handle USAGE failure separately

command_ret_t enum contains 3 return values but only two are handled
now. Extend cmd_process_error() and handle CMD_RET_USAGE separately.

These commands are affected by this change.
cmd/demo.c
cmd/efi.c
cmd/gpio.c
cmd/qfw.c
cmd/x86/fsp.c
test/dm/cmd_dm.c

And scripts shouldn't be affected because return value is not 0. But
every command implementation can choose what it is correct to pass.
I would expect that RET_USAGE is called when parameters are not
correctly passed (have incorrect value, missing parameters)
and RET_FAILURE when correct parameters are passed but command fails.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Simon Glass <sjg@chromum.org>
common/command.c
include/command.h