]> git.dujemihanovic.xyz Git - u-boot.git/commit
efi_loader: fix building crt0 on arm
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Wed, 31 Jan 2018 18:45:35 +0000 (18:45 +0000)
committerAlexander Graf <agraf@suse.de>
Fri, 9 Feb 2018 23:24:00 +0000 (00:24 +0100)
commit268ec6e00e57497b96ebd4a5a5dc60b821e13fb0
treeacee912af7ac8ee877494fe0fadc3d77d596892c
parent1811a928c6c7604d6d05a84b4d552a7c31b4994e
efi_loader: fix building crt0 on arm

Before the patch an undefined constant EFI_SUBSYSTEM was used in the
crt0 code. The current version of binutils does not swallow the error.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888403

The necessary constant IMAGE_SUBSYSTEM_EFI_APPLICATION is already
defined in pe.h. So let's factor out asm-generic/pe.h for the
image subsystem constants and use it in our assembler code.

IMAGE_SUBSYSTEM_SAL_RUNTIME_DRIVER does not exist in the specification
let's use IMAGE_SUBSYSTEM_EFI_ROM instead.

The include pe.h is only used in code maintained by Alex so let him be the
maintainer here too.

Reported-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Tested-by: Vagrant Cascadian <vagrant@debian.org>
Signed-off-by: Alexander Graf <agraf@suse.de>
MAINTAINERS
arch/arm/lib/crt0_aarch64_efi.S
arch/arm/lib/crt0_arm_efi.S
include/asm-generic/pe.h [new file with mode: 0644]
include/pe.h
lib/efi_loader/efi_image_loader.c