]> git.dujemihanovic.xyz Git - u-boot.git/commit
phy: Set phy->dev to NULL when generic_phy_get_by_index_nodev() fails
authorJonas Karlman <jonas@kwiboo.se>
Thu, 31 Aug 2023 22:16:35 +0000 (22:16 +0000)
committerTom Rini <trini@konsulko.com>
Wed, 13 Sep 2023 19:52:20 +0000 (15:52 -0400)
commit14639bf14d824d9fbcfd918f0e7924c7f7065422
tree846bd0c2783be0096a440ce61a29d0c0568c6360
parentfeb4b919abf39f39faf660ef3d9aedebb54f5db5
phy: Set phy->dev to NULL when generic_phy_get_by_index_nodev() fails

Generic phy helpers typically use generic_phy_valid() to determine if
the helper should perform its function on a passed struct phy.
generic_phy_valid() treat any struct phy having phy->dev set as valid.

With generic_phy_get_by_index_nodev() setting phy->dev to a valid struct
udevice early, there can be situations where the struct phy is returned
as valid when initialization in fact failed and returned an error.

Fix this by setting phy->dev back to NULL when any of the calls to
of_xlate ops, device_get_supply_regulator or phy_alloc_counts fail. Also
extend the dm_test_phy_base test with a test where of_xlate ops fail.

Fixes: 72e5016f878d ("drivers: phy: add generic PHY framework")
Fixes: b9688df3cbf4 ("drivers: phy: Set phy->dev to NULL when generic_phy_get_by_index() fails")
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
arch/sandbox/dts/test.dts
drivers/phy/phy-uclass.c
test/dm/phy.c