From cf2cf8510a10d954ea46b4a49a7bf9d95cccf4bd Mon Sep 17 00:00:00 2001
From: =?utf8?q?Marek=20Beh=C3=BAn?= <marek.behun@nic.cz>
Date: Tue, 24 Apr 2018 17:21:29 +0200
Subject: [PATCH] net: mvneta: Fix fault when wrong device tree
The driver does not check id phy_connect failed (for example on wrong
property name in device tree). In such a case a fault occurs and the
CPU is restarted.
Signed-off-by: Marek Behun <marek.behun@nic.cz>
Reviewed-by: Stefan Roese <sr@denx.de>
Signed-off-by: Stefan Roese <sr@denx.de>
---
drivers/net/mvneta.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c
index 6eacd6116a..7036b517b4 100644
--- a/drivers/net/mvneta.c
+++ b/drivers/net/mvneta.c
@@ -1562,6 +1562,10 @@ static int mvneta_start(struct udevice *dev)
phydev = phy_connect(pp->bus, pp->phyaddr, dev,
pp->phy_interface);
+ if (!phydev) {
+ printf("phy_connect failed\n");
+ return -ENODEV;
+ }
pp->phydev = phydev;
phy_config(phydev);
--
2.39.5