From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Date: Thu, 11 Jan 2024 08:25:35 +0000 (+0100)
Subject: cmd: efidebug: check pointer after memory allocation
X-Git-Tag: v2025.01-rc5-pxa1908~713^2
X-Git-Url: http://git.dujemihanovic.xyz/img/html/static/login.html?a=commitdiff_plain;h=55125bbfb48cb1330a692059bc972810f77b984a;p=u-boot.git

cmd: efidebug: check pointer after memory allocation

After calling efi_alloc() we must check that the return value is not NULL.

Fixes: f01c961ee34c ("cmd: efidebug: add uri device path")
Addresses-Coverity-ID: 477185 Dereference null return value
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---

diff --git a/cmd/efidebug.c b/cmd/efidebug.c
index 836014ab8e..aa8523797e 100644
--- a/cmd/efidebug.c
+++ b/cmd/efidebug.c
@@ -754,6 +754,10 @@ static int efi_boot_add_uri(int argc, char *const argv[], u16 *var_name16,
 
 	uridp_len = sizeof(struct efi_device_path) + strlen(argv[3]) + 1;
 	uridp = efi_alloc(uridp_len + sizeof(END));
+	if (!uridp) {
+		log_err("Out of memory\n");
+		return CMD_RET_FAILURE;
+	}
 	uridp->dp.type = DEVICE_PATH_TYPE_MESSAGING_DEVICE;
 	uridp->dp.sub_type = DEVICE_PATH_SUB_TYPE_MSG_URI;
 	uridp->dp.length = uridp_len;