From: Pali Rohár <pali@kernel.org>
Date: Sun, 8 Jan 2023 22:28:39 +0000 (+0100)
Subject: tools: mkimage: Print human readable error when -d is not specified
X-Git-Url: http://git.dujemihanovic.xyz/img/%7B%7B%20%28.OutputFormats.Get?a=commitdiff_plain;h=2f6855a6aa8d55d8341f454f87cabc784a890193;p=u-boot.git

tools: mkimage: Print human readable error when -d is not specified

When asking mkimage to create a new image file and option -d is not
specified then mkimage show human unfriendly error message:

  mkimage: Can't open (null): Bad address

Without debugger it is hard to debug what is the issue. Function open() is
being called with file name set to NULL. So add a check for this and if it
happens then show human readable message that option -d was not specified.

Signed-off-by: Pali Rohár <pali@kernel.org>
---

diff --git a/tools/mkimage.c b/tools/mkimage.c
index 0b342159e5..5e0bb91cea 100644
--- a/tools/mkimage.c
+++ b/tools/mkimage.c
@@ -600,6 +600,11 @@ int main(int argc, char **argv)
 	}
 
 	if ((params.type != IH_TYPE_MULTI) && (params.type != IH_TYPE_SCRIPT)) {
+		if (!params.datafile) {
+			fprintf(stderr, "%s: Option -d with image data file was not specified\n",
+				params.cmdname);
+			exit(EXIT_FAILURE);
+		}
 		dfd = open(params.datafile, O_RDONLY | O_BINARY);
 		if (dfd < 0) {
 			fprintf(stderr, "%s: Can't open %s: %s\n",