acpi: x86: Move MADT to common code

Write MADT in common code and let the SoC fill out the body by
calling acpi_fill_madt() which must be implemented at SoC level.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Cc: Simon Glass <sjg@chromium.org>
Cc: Bin Meng <bmeng.cn@gmail.com>

diff --git a/arch/sandbox/lib/Makefile b/arch/sandbox/lib/Makefile
index d7d15a50bb6c59bf2dd95b8ea3ba6b751fd4c08f..5d7beb250cd8b43c9d83ea6d05c6aaeeadfb799b 100644 (file)
--- a/arch/sandbox/lib/Makefile
+++ b/arch/sandbox/lib/Makefile
@@ -5,7 +5,8 @@
 # (C) Copyright 2002-2006
 # Wolfgang Denk, DENX Software Engineering, wd@denx.de.
 
-obj-y                  += fdt_fixup.o interrupts.o
-obj-$(CONFIG_PCI)      += pci_io.o
-obj-$(CONFIG_CMD_BOOTM) += bootm.o
-obj-$(CONFIG_CMD_BOOTZ) += bootm.o
+obj-y                          += fdt_fixup.o interrupts.o
+obj-$(CONFIG_PCI)              += pci_io.o
+obj-$(CONFIG_CMD_BOOTM)                += bootm.o
+obj-$(CONFIG_CMD_BOOTZ)                += bootm.o
+obj-$(CONFIG_$(SPL_)ACPIGEN)   += acpi_table.o

diff --git a/arch/sandbox/lib/acpi_table.c b/arch/sandbox/lib/acpi_table.c
index 10b7ce441aef9e307d735b26866e8a4b71ec1710..90bb96d1e359c3bc2994a22bbe1d778ff2e795e2 100644 (file)
--- a/arch/sandbox/lib/acpi_table.c
+++ b/arch/sandbox/lib/acpi_table.c
@@ -3,4 +3,9 @@
 
 void acpi_fill_fadt(struct acpi_fadt *fadt)
 {
-}
\ No newline at end of file
+}
+
+void *acpi_fill_madt(struct acpi_madt *madt, struct acpi_ctx *ctx)
+{
+       return ctx->current;
+}

diff --git a/arch/x86/cpu/intel_common/acpi.c b/arch/x86/cpu/intel_common/acpi.c
index 29676b4abfae66eed7897dfc7150c5e8db578286..982149b394e150cd6448dddc189b1c2ea09ab933 100644 (file)
--- a/arch/x86/cpu/intel_common/acpi.c
+++ b/arch/x86/cpu/intel_common/acpi.c
@@ -19,6 +19,7 @@
 #include <asm/global_data.h>
 #include <asm/intel_acpi.h>
 #include <asm/ioapic.h>
+#include <asm/lapic.h>
 #include <asm/mpspec.h>
 #include <asm/smm.h>
 #include <asm/turbo.h>
@@ -80,33 +81,40 @@ static int acpi_sci_irq(void)
        return sci_irq;
 }
 
-static unsigned long acpi_madt_irq_overrides(unsigned long current)
+static void *acpi_madt_irq_overrides(void *current)
 {
        int sci = acpi_sci_irq();
        u16 flags = MP_IRQ_TRIGGER_LEVEL;
 
-       if (sci < 0)
-               return log_msg_ret("sci irq", sci);
+       if (sci < 0) {
+               log_err("sci irq %d", sci);
+               return current;
+       }
 
        /* INT_SRC_OVR */
-       current += acpi_create_madt_irqoverride((void *)current, 0, 0, 2, 0);
+       current += acpi_create_madt_irqoverride(current, 0, 0, 2, 0);
 
        flags |= arch_madt_sci_irq_polarity(sci);
 
        /* SCI */
        current +=
-           acpi_create_madt_irqoverride((void *)current, 0, sci, sci, flags);
+           acpi_create_madt_irqoverride(current, 0, sci, sci, flags);
 
        return current;
 }
 
-u32 acpi_fill_madt(u32 current)
+void *acpi_fill_madt(struct acpi_madt *madt, struct acpi_ctx *ctx)
 {
+       void *current = ctx->current;
+
+       madt->lapic_addr = LAPIC_DEFAULT_BASE;
+       madt->flags = ACPI_MADT_PCAT_COMPAT;
+
        /* Local APICs */
        current += acpi_create_madt_lapics(current);
 
        /* IOAPIC */
-       current += acpi_create_madt_ioapic((void *)current, 2, IO_APIC_ADDR, 0);
+       current += acpi_create_madt_ioapic(current, 2, IO_APIC_ADDR, 0);
 
        return acpi_madt_irq_overrides(current);
 }

diff --git a/arch/x86/cpu/tangier/acpi.c b/arch/x86/cpu/tangier/acpi.c
index 1c73a9dbfece1c0562eaf02cf3abfc2ef7ca08fe..3d117878615234dec7a8e0c2c51a7ec145a739d3 100644 (file)
--- a/arch/x86/cpu/tangier/acpi.c
+++ b/arch/x86/cpu/tangier/acpi.c
@@ -10,6 +10,7 @@
 #include <mapmem.h>
 #include <acpi/acpi_table.h>
 #include <asm/ioapic.h>
+#include <asm/lapic.h>
 #include <asm/mpspec.h>
 #include <asm/tables.h>
 #include <asm/arch/global_nvs.h>
@@ -31,8 +32,13 @@ void acpi_fill_fadt(struct acpi_fadt *fadt)
        fadt->minor_revision = 2;
 }
 
-u32 acpi_fill_madt(u32 current)
+void *acpi_fill_madt(struct acpi_madt *madt, struct acpi_ctx *ctx)
 {
+       void *current = ctx->current;
+
+       madt->lapic_addr = LAPIC_DEFAULT_BASE;
+       madt->flags = ACPI_MADT_PCAT_COMPAT;
+
        current += acpi_create_madt_lapics(current);
 
        current += acpi_create_madt_ioapic((struct acpi_madt_ioapic *)current,

diff --git a/arch/x86/include/asm/acpi_table.h b/arch/x86/include/asm/acpi_table.h
index 3988898f66eb4b7e2cd83be0899aa4ff94cb1522..3254bbc380fe1cbccea411d0b91d27e11c72bda2 100644 (file)
--- a/arch/x86/include/asm/acpi_table.h
+++ b/arch/x86/include/asm/acpi_table.h
@@ -24,14 +24,13 @@ struct acpi_table_header;
 
 /* These can be used by the target port */
 
-int acpi_create_madt_lapics(u32 current);
+int acpi_create_madt_lapics(void *current);
 int acpi_create_madt_ioapic(struct acpi_madt_ioapic *ioapic, u8 id,
                            u32 addr, u32 gsi_base);
 int acpi_create_madt_irqoverride(struct acpi_madt_irqoverride *irqoverride,
                                 u8 bus, u8 source, u32 gsirq, u16 flags);
 int acpi_create_madt_lapic_nmi(struct acpi_madt_lapic_nmi *lapic_nmi,
                               u8 cpu, u16 flags, u8 lint);
-u32 acpi_fill_madt(u32 current);
 int acpi_create_mcfg_mmconfig(struct acpi_mcfg_mmconfig *mmconfig, u32 base,
                              u16 seg_nr, u8 start, u8 end);
 

diff --git a/arch/x86/lib/acpi_table.c b/arch/x86/lib/acpi_table.c
index ff02ce80d15f8bd25a2631cce24b4c1f6a6e5b4e..3186e48d63b08a96d1669dfe6282c172066971f5 100644 (file)
--- a/arch/x86/lib/acpi_table.c
+++ b/arch/x86/lib/acpi_table.c
@@ -40,7 +40,7 @@ static int acpi_create_madt_lapic(struct acpi_madt_lapic *lapic,
        return lapic->length;
 }
 
-int acpi_create_madt_lapics(u32 current)
+int acpi_create_madt_lapics(void *current)
 {
        struct udevice *dev;
        int total_length = 0;
@@ -100,23 +100,28 @@ int acpi_create_madt_lapic_nmi(struct acpi_madt_lapic_nmi *lapic_nmi,
        return lapic_nmi->length;
 }
 
-static int acpi_create_madt_irq_overrides(u32 current)
+static int acpi_create_madt_irq_overrides(void *current)
 {
        struct acpi_madt_irqoverride *irqovr;
        u16 sci_flags = MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_HIGH;
        int length = 0;
 
-       irqovr = (void *)current;
+       irqovr = current;
        length += acpi_create_madt_irqoverride(irqovr, 0, 0, 2, 0);
 
-       irqovr = (void *)(current + length);
+       irqovr = current + length;
        length += acpi_create_madt_irqoverride(irqovr, 0, 9, 9, sci_flags);
 
        return length;
 }
 
-__weak u32 acpi_fill_madt(u32 current)
+__weak void *acpi_fill_madt(struct acpi_madt *madt, struct acpi_ctx *ctx)
 {
+       void *current = ctx->current;
+
+       madt->lapic_addr = LAPIC_DEFAULT_BASE;
+       madt->flags = ACPI_MADT_PCAT_COMPAT;
+
        current += acpi_create_madt_lapics(current);
 
        current += acpi_create_madt_ioapic((struct acpi_madt_ioapic *)current,
@@ -127,39 +132,6 @@ __weak u32 acpi_fill_madt(u32 current)
        return current;
 }
 
-int acpi_write_madt(struct acpi_ctx *ctx, const struct acpi_writer *entry)
-{
-       struct acpi_table_header *header;
-       struct acpi_madt *madt;
-       u32 current;
-
-       madt = ctx->current;
-
-       memset(madt, '\0', sizeof(struct acpi_madt));
-       header = &madt->header;
-
-       /* Fill out header fields */
-       acpi_fill_header(header, "APIC");
-       header->length = sizeof(struct acpi_madt);
-       header->revision = ACPI_MADT_REV_ACPI_3_0;
-
-       madt->lapic_addr = LAPIC_DEFAULT_BASE;
-       madt->flags = ACPI_MADT_PCAT_COMPAT;
-
-       current = (u32)madt + sizeof(struct acpi_madt);
-       current = acpi_fill_madt(current);
-
-       /* (Re)calculate length and checksum */
-       header->length = current - (u32)madt;
-
-       header->checksum = table_compute_checksum((void *)madt, header->length);
-       acpi_add_table(ctx, madt);
-       acpi_inc(ctx, madt->header.length);
-
-       return 0;
-}
-ACPI_WRITER(5x86, NULL, acpi_write_madt, 0);
-
 /**
  * acpi_create_tcpa() - Create a TCPA table
  *

diff --git a/include/acpi/acpi_table.h b/include/acpi/acpi_table.h
index 19cf0fb43cac949d666a8174fc28715afc7b7b98..c356df72bae2d51b94564163d4d0cb2df2ece279 100644 (file)
--- a/include/acpi/acpi_table.h
+++ b/include/acpi/acpi_table.h
@@ -963,6 +963,17 @@ int acpi_fill_csrt(struct acpi_ctx *ctx);
  */
 void acpi_fill_fadt(struct acpi_fadt *fadt);
 
+/**
+ * acpi_fill_madt() - Fill out the body of the MADT
+ *
+ * Must be implemented in SoC specific code.
+ *
+ * @madt: The MADT to update
+ * @ctx: ACPI context to write MADT sub-tables to
+ * @return Pointer to the end of tables, where the next tables can be written
+ */
+void *acpi_fill_madt(struct acpi_madt *madt, struct acpi_ctx *ctx);
+
 /**
  * acpi_get_rsdp_addr() - get ACPI RSDP table address
  *

diff --git a/lib/acpi/acpi_table.c b/lib/acpi/acpi_table.c
index 9eb0b507a09a130dd22dfd99f86e0ea9cbcd1e69..639d78125f63046d7d20b46bddb5181d24694297 100644 (file)
--- a/lib/acpi/acpi_table.c
+++ b/lib/acpi/acpi_table.c
@@ -240,6 +240,37 @@ int acpi_write_fadt(struct acpi_ctx *ctx, const struct acpi_writer *entry)
 
 ACPI_WRITER(5fadt, "FADT", acpi_write_fadt, 0);
 
+int acpi_write_madt(struct acpi_ctx *ctx, const struct acpi_writer *entry)
+{
+       struct acpi_table_header *header;
+       struct acpi_madt *madt;
+       void *current;
+
+       madt = ctx->current;
+
+       memset(madt, '\0', sizeof(struct acpi_madt));
+       header = &madt->header;
+
+       /* Fill out header fields */
+       acpi_fill_header(header, "APIC");
+       header->length = sizeof(struct acpi_madt);
+       header->revision = ACPI_MADT_REV_ACPI_3_0;
+
+       acpi_inc(ctx, sizeof(struct acpi_madt));
+       current = acpi_fill_madt(madt, ctx);
+
+       /* (Re)calculate length and checksum */
+       header->length = (uintptr_t)current - (uintptr_t)madt;
+
+       header->checksum = table_compute_checksum((void *)madt, header->length);
+       acpi_add_table(ctx, madt);
+       ctx->current = (void *)madt + madt->header.length;
+
+       return 0;
+}
+
+ACPI_WRITER(5madt, "MADT", acpi_write_madt, 0);
+
 void acpi_create_dbg2(struct acpi_dbg2_header *dbg2,
                      int port_type, int port_subtype,
                      struct acpi_gen_regaddr *address, u32 address_size,