projects
/
u-boot.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ec19e11
)
lib: sparse: Fix error checking for write_sparse_chunk_raw
author
Sean Anderson
<sean.anderson@seco.com>
Thu, 1 Feb 2024 18:18:51 +0000
(13:18 -0500)
committer
Mattijs Korpershoek
<mkorpershoek@baylibre.com>
Fri, 9 Feb 2024 08:42:04 +0000
(09:42 +0100)
The return value of write_sparse_chunk_raw is unsigned, so the existing
check has no effect. Use IS_ERR_VALUE to detect error instead, which is
what write_sparse_chunk_raw does itself.
Fixes: 62649165cb0 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Link:
https://lore.kernel.org/u-boot/1b323ec3-59b0-490b-a2f0-fd961dafcf49@moroto.mountain/
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Link:
https://lore.kernel.org/r/20240201181851.221701-1-sean.anderson@seco.com
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
lib/image-sparse.c
patch
|
blob
|
history
diff --git
a/lib/image-sparse.c
b/lib/image-sparse.c
index f82890646920657d0acb51029d32945784eb7cd5..09225692e9b1efb4c7d45bdc464b86689df887c1 100644
(file)
--- a/
lib/image-sparse.c
+++ b/
lib/image-sparse.c
@@
-211,7
+211,7
@@
int write_sparse_image(struct sparse_storage *info,
blks = write_sparse_chunk_raw(info, blk, blkcnt,
data, response);
- if (
blks < 0
)
+ if (
IS_ERR_VALUE(blks)
)
return -1;
blk += blks;