]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
power: rk8xx: fix display name for RK808
authorQuentin Schulz <quentin.schulz@cherry.de>
Mon, 17 Jun 2024 16:48:51 +0000 (18:48 +0200)
committerKever Yang <kever.yang@rock-chips.com>
Wed, 17 Jul 2024 04:25:52 +0000 (12:25 +0800)
Commit 2ce40542e0eb ("power: rk8xx: properly print all supported PMICs
name") fixed all PMICs name that were broken but broke the only one that
was not broken already: RK808. This one is a special case because the ID
registers are marked as reserved and always return 0, so the variant
cannot be derived the same way it is done for other PMICs from Rockchip.

Fixes: 2ce40542e0eb ("power: rk8xx: properly print all supported PMICs name")
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
drivers/power/pmic/rk8xx.c

index 617bb511e4e050d64a41ba9871d84b039d9de0f5..4d5a5ceafadbb136a482d24abe0f0636bec24e00 100644 (file)
@@ -281,6 +281,8 @@ static int rk8xx_probe(struct udevice *dev)
        show_variant = bitfield_extract_by_mask(priv->variant, RK8XX_ID_MSK);
        switch (priv->variant) {
        case RK808_ID:
+               /* RK808 ID is 0x0000, so fix show_variant for that PMIC */
+               show_variant = 0x808;
                break;
        case RK805_ID:
        case RK816_ID: