From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Date: Thu, 10 Nov 2022 08:21:24 +0000 (+0200)
Subject: efi_loader: initialize return values in efi_uninstall_multiple_protocol_interfaces_int()
X-Git-Tag: v2025.01-rc5-pxa1908~1210^2~7
X-Git-Url: http://git.dujemihanovic.xyz/html/static/git-logo.png?a=commitdiff_plain;h=9fb3269ab39d3b3b1db43296b5d2619238eaa8b0;p=u-boot.git

efi_loader: initialize return values in efi_uninstall_multiple_protocol_interfaces_int()

If the va_list we got handed over contains no protocols we must return
EFI_SUCCESS.  However in that case the current code just returns
an unintialized value.
Fix that by setting the return value in the variable definition

Addresses-Coverity: CID 376195:  ("Uninitialized variables  (UNINIT)")
Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---

diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index a56021559b..253f9f75ef 100644
--- a/lib/efi_loader/efi_boottime.c
+++ b/lib/efi_loader/efi_boottime.c
@@ -2754,7 +2754,7 @@ efi_uninstall_multiple_protocol_interfaces_int(efi_handle_t handle,
 {
 	const efi_guid_t *protocol;
 	void *protocol_interface;
-	efi_status_t ret;
+	efi_status_t ret = EFI_SUCCESS;
 	size_t i = 0;
 	efi_va_list argptr_copy;