]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
power: imx8m-power-domain: Add delay to align with kernel driver
authorFabio Estevam <festevam@denx.de>
Sat, 6 May 2023 16:14:02 +0000 (13:14 -0300)
committerStefano Babic <sbabic@denx.de>
Tue, 11 Jul 2023 12:40:03 +0000 (14:40 +0200)
In the imx8m power domain kernel driver, there is an extra udelay(5)
prior to requesting the domain to power up:

https://github.com/torvalds/linux/blob/v6.3/drivers/soc/imx/gpcv2.c#L347-L375

Haven't observed any issues due to the lack of this delay in U-Boot yet,
but better to align it with the kernel driver implementation.

Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Marek Vasut <marex@denx.de>
drivers/power/domain/imx8m-power-domain.c

index 145f6ec0cd3221825cea9933c51029a6a99f2a5b..df5d7d695621af3fa1b70d21a39e5f6a96283e34 100644 (file)
@@ -338,6 +338,9 @@ static int imx8m_power_domain_on(struct power_domain *power_domain)
                }
        }
 
+       /* delay for reset to propagate */
+       udelay(5);
+
        if (domain->bits.pxx) {
                /* request the domain to power up */
                setbits_le32(base + regs->pup, domain->bits.pxx);