From 7db25d99b21ae7b2a04153a93afe7692c86992ac Mon Sep 17 00:00:00 2001
From: Ehsan Mohandesi <emohandesi@microsoft.com>
Date: Fri, 13 Jan 2023 09:27:41 -0800
Subject: [PATCH] net: ipv6: Fixed IPv6 string to address conversion off-by-one
error
One extra character was being checked in the IPv6 string which caused the
last character of the address to be neither '\0' nor ':'. This raises an
error condition and causes the function to always return an error. This
issue was resolved by this fix.
Signed-off-by: Ehsan Mohandesi <emohandesi@microsoft.com>
Reviewed-by: Viacheslav Mitrofanov <v.v.mitrofanov@yadro.com>
---
net/tftp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tftp.c b/net/tftp.c
index 51e062bddf..88e71e67de 100644
--- a/net/tftp.c
+++ b/net/tftp.c
@@ -845,7 +845,7 @@ void tftp_start(enum proto_t protocol)
e = strchr(net_boot_file_name, ']');
len = e - s;
if (s && e) {
- string_to_ip6(s + 1, len, &tftp_remote_ip6);
+ string_to_ip6(s + 1, len - 1, &tftp_remote_ip6);
strlcpy(tftp_filename, e + 2, MAX_LEN);
} else {
strlcpy(tftp_filename, net_boot_file_name, MAX_LEN);
--
2.39.5