]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
rockchip: rock5b-rk3588: use DRAM banks from ATAGS
authorQuentin Schulz <quentin.schulz@theobroma-systems.com>
Thu, 25 Apr 2024 10:46:29 +0000 (12:46 +0200)
committerKever Yang <kever.yang@rock-chips.com>
Fri, 26 Apr 2024 07:47:05 +0000 (15:47 +0800)
RK3588-based devices now support creating DRAM banks with proper holes
by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism
instead.

Since ft_board_setup isn't defined anymore, there's no need for
selecting CONFIG_OF_BOARD_SETUP.

Similarly, because the rock5b-rk3588.c would be empty, it is simply
removed, with the (would-be-empty) Makefile as well.

The CONFIG_NR_DRAM_BANK now defaults to 10 which is a safe bet for
reading banks from ATAGS, so let's use the default value instead.

Co-developed-by: Chris Morgan <macromorgan@hotmail.com>
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
board/radxa/rock5b-rk3588/Makefile [deleted file]
board/radxa/rock5b-rk3588/rock5b-rk3588.c [deleted file]
configs/rock5b-rk3588_defconfig

diff --git a/board/radxa/rock5b-rk3588/Makefile b/board/radxa/rock5b-rk3588/Makefile
deleted file mode 100644 (file)
index 95d8135..0000000
+++ /dev/null
@@ -1,6 +0,0 @@
-# SPDX-License-Identifier:     GPL-2.0+
-#
-# Copyright (c) 2022 Collabora Ltd.
-#
-
-obj-y += rock5b-rk3588.o
diff --git a/board/radxa/rock5b-rk3588/rock5b-rk3588.c b/board/radxa/rock5b-rk3588/rock5b-rk3588.c
deleted file mode 100644 (file)
index 5c3b52b..0000000
+++ /dev/null
@@ -1,39 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+
-/*
- * Copyright (c) 2023 Collabora Ltd.
- */
-
-#include <fdtdec.h>
-#include <fdt_support.h>
-
-#ifdef CONFIG_OF_BOARD_SETUP
-int rock5b_add_reserved_memory_fdt_nodes(void *new_blob)
-{
-       struct fdt_memory gap1 = {
-               .start = 0x3fc000000,
-               .end = 0x3fc4fffff,
-       };
-       struct fdt_memory gap2 = {
-               .start = 0x3fff00000,
-               .end = 0x3ffffffff,
-       };
-       unsigned long flags = FDTDEC_RESERVED_MEMORY_NO_MAP;
-       unsigned int ret;
-
-       /*
-        * Inject the reserved-memory nodes into the DTS
-        */
-       ret = fdtdec_add_reserved_memory(new_blob, "gap1", &gap1,  NULL, 0,
-                                        NULL, flags);
-       if (ret)
-               return ret;
-
-       return fdtdec_add_reserved_memory(new_blob, "gap2", &gap2,  NULL, 0,
-                                         NULL, flags);
-}
-
-int ft_board_setup(void *blob, struct bd_info *bd)
-{
-       return rock5b_add_reserved_memory_fdt_nodes(blob);
-}
-#endif
index 8af56baf04d7fec5ec3cc5963caa3ec5881d5e3c..9e14b14af7c6c81488ea76808e491b02a234a15e 100644 (file)
@@ -3,7 +3,6 @@ CONFIG_SKIP_LOWLEVEL_INIT=y
 CONFIG_SYS_HAS_NONCACHED_MEMORY=y
 CONFIG_COUNTER_FREQUENCY=24000000
 CONFIG_ARCH_ROCKCHIP=y
-CONFIG_NR_DRAM_BANKS=2
 CONFIG_SF_DEFAULT_SPEED=24000000
 CONFIG_SF_DEFAULT_MODE=0x2000
 CONFIG_DEFAULT_DEVICE_TREE="rk3588-rock-5b"
@@ -24,7 +23,6 @@ CONFIG_FIT_VERBOSE=y
 CONFIG_SPL_FIT_SIGNATURE=y
 CONFIG_SPL_LOAD_FIT=y
 CONFIG_LEGACY_IMAGE_FORMAT=y
-CONFIG_OF_BOARD_SETUP=y
 CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-rock-5b.dtb"
 # CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y