]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
thermal: imx_tmu: Fix the polling default
authorFabio Estevam <festevam@denx.de>
Wed, 23 Aug 2023 17:59:08 +0000 (14:59 -0300)
committerStefano Babic <stefano.babic@swupdate.org>
Mon, 4 Sep 2023 15:26:44 +0000 (17:26 +0200)
When the 'polling-delay' property is not passed via devicetree,
pdata->polling_delay keeps at 0. This causes the imx_tmu driver to get
stuck inside the busy while() loop when the CPU temperature is above
the alert point.

Fix this problem by passing a one second polling interval, which provides
a proper delay to let the system to cool down and exit the while() loop
when the temperature is below the alert point.

Signed-off-by: Fabio Estevam <festevam@denx.de>
drivers/thermal/imx_tmu.c

index 97efc5504439873d03665eb61c6274fd4a348184..d9a04eaf79fb73db33fc20b05cd97936892d329d 100644 (file)
@@ -37,6 +37,7 @@ DECLARE_GLOBAL_DATA_PTR;
 #define TER_ADC_PD             0x40000000
 #define TER_ALPF               0x3
 
+#define IMX_TMU_POLLING_DELAY_MS       1000
 /*
  * i.MX TMU Registers
  */
@@ -574,6 +575,8 @@ static int imx_tmu_parse_fdt(struct udevice *dev)
 
        dev_dbg(dev, "%s\n", __func__);
 
+       pdata->polling_delay = IMX_TMU_POLLING_DELAY_MS;
+
        if (pdata->zone_node) {
                pdata->regs = (union tmu_regs *)dev_read_addr_ptr(dev);
 
@@ -602,7 +605,8 @@ static int imx_tmu_parse_fdt(struct udevice *dev)
 
        dev_dbg(dev, "args.args_count %d, id %d\n", args.args_count, pdata->id);
 
-       pdata->polling_delay = dev_read_u32_default(dev, "polling-delay", 1000);
+       pdata->polling_delay = dev_read_u32_default(dev, "polling-delay",
+                                                   IMX_TMU_POLLING_DELAY_MS);
 
        trips_np = ofnode_path("/thermal-zones/cpu-thermal/trips");
        ofnode_for_each_subnode(trips_np, trips_np) {