]> git.dujemihanovic.xyz Git - u-boot.git/commit
apalis-imx8: Fix sc_misc_otp_fuse_read() error check
authorFabio Estevam <festevam@gmail.com>
Wed, 13 Mar 2024 00:59:41 +0000 (21:59 -0300)
committerFabio Estevam <festevam@gmail.com>
Sun, 17 Mar 2024 20:59:50 +0000 (17:59 -0300)
commitcd7af7ee5a06b367fb0f866346ea82c69b96e2f8
treed5efde0396d201988e7eb05e271af51b3d42b787
parentfdd529fa624e8b235a949b63b932d3eb1e9641b9
apalis-imx8: Fix sc_misc_otp_fuse_read() error check

Commit bfb3409d676f ("imx: toradex/apalis-imx8: correct SCU API usage")
made an incorrect logic change in the error code check of
sc_misc_otp_fuse_read():

-       if (scierr == SC_ERR_NONE) {
+       if (scierr) {
                /* QP has one A72 core disabled */
                is_quadplus = ((val >> 4) & 0x3) != 0x0;
        }

The other changes in this commit are correct.

sc_misc_otp_fuse_read() returns 0 on a successful fuse read.

This inversion causes board_mem_get_layout() to report incorrect RAM size.

Go back the original error check logic to fix the problem.

Fixes: bfb3409d676f ("imx: toradex/apalis-imx8: correct SCU API usage")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
board/toradex/apalis-imx8/apalis-imx8.c