]> git.dujemihanovic.xyz Git - u-boot.git/commit
efi_selftests: fix protocol repeated selftesting
authorIlias Apalodimas <ilias.apalodimas@linaro.org>
Tue, 13 Jun 2023 13:23:06 +0000 (16:23 +0300)
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Fri, 16 Jun 2023 04:48:46 +0000 (06:48 +0200)
commit5669591dd8d2b21bc79237b161107300eb7f2b12
tree6120a7d1a99c25b50896a7d932d431145570f5a4
parent3cc2b9f5b982ff3a192202b6d422eeb1893fa667
efi_selftests: fix protocol repeated selftesting

Running the protocols  selftest more than one times fails with

=> setenv efi_selftest 'manage protocols' && bootefi selftest
Testing EFI API implementation
Selected test: 'manage protocols'
Setting up 'manage protocols'
Setting up 'manage protocols' succeeded
Executing 'manage protocols'
Executing 'manage protocols' succeeded
Tearing down 'manage protocols'
Tearing down 'manage protocols' succeeded
Summary: 0 failures

=> bootefi selftest
Testing EFI API implementation
Selected test: 'manage protocols'
Setting up 'manage protocols'
lib/efi_selftest/efi_selftest_manageprotocols.c(88):
ERROR: InstallProtocolInterface failed
lib/efi_selftest/efi_selftest.c(89):
ERROR: Setting up 'manage protocols' failed
Tearing down 'manage protocols'
Tearing down 'manage protocols' succeeded
Summary: 1 failures

The reason is that we don't set the handles to NULL after deleting and
freeing them.  As a result the subsequent protocol installation will try
to use an existing handle which we just removed that from our object list.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
lib/efi_selftest/efi_selftest_manageprotocols.c