]> git.dujemihanovic.xyz Git - u-boot.git/commit
firmware: ti_sci: fix the secure_hdr in do_xfer
authorDhruva Gole <d-gole@ti.com>
Tue, 30 Jan 2024 14:59:59 +0000 (20:29 +0530)
committerTom Rini <trini@konsulko.com>
Tue, 6 Feb 2024 21:31:06 +0000 (16:31 -0500)
commit0c4e36d65f6c25e5016235cc3f1e97c8d237f416
treebdd462165b9f66fe4f10d6a7126b80ffe3e2549a
parent94cfc6fc96d2e718026d6aed9471994489a192f0
firmware: ti_sci: fix the secure_hdr in do_xfer

The ti_sci driver in U-Boot has support for secure_msg as part of it's
do_xfer function. This let's U-boot send secure messages during boot up.

The protocol to send such secure messages is described as part of the
struct ti_sci_secure_msg_hdr. As part of this, there are 2 fields for
checksum and reserved that occupy the first 4 bytes of any secure
message. This is called as the secure_hdr.

As of now, the secure_hdr needs to be 0 init-ed before sending secure
messages. However the existing code was never putting the zero-inited vars
into the secure_buf, leading to possibility of the first 4 bytes of
secure_buf being possibly garbage.

Fix this by initialising the secure_hdr itself to the secure_buf
location, thus when we make secure_hdr members 0, it automatically ensures
the first 4 bytes of secure_buf are 0.

Fixes: 32cd25128bd849 ("firmware: Add basic support for TI System Control Interface (TI SCI)")
Reviewed-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Dhruva Gole <d-gole@ti.com>
drivers/firmware/ti_sci.c