From: Ye Li Date: Tue, 24 Sep 2024 07:32:00 +0000 (+0800) Subject: net: fec_mxc: Skip recv packet process when fec is halted X-Git-Url: http://git.dujemihanovic.xyz/html/static/%7B%7B%20.RelPermalink%20%7D%7D?a=commitdiff_plain;h=99abeaa648052e8e99682f046b8dfd3739b4e181;p=u-boot.git net: fec_mxc: Skip recv packet process when fec is halted After FEC is halted by calling fec_halt callback, we should not continue receiving packet. Otherwise it will process previous pending interrupts on EIR register and uses wrong rbd index as this has been reset to 0. The GRA interrupt which is triggered by issuing graceful stop command to FEC transmitter in fec_halt is processed in this case. It causes wrong receive buffer descriptors be used by FEC in next time. Signed-off-by: Ye Li Reviewed-by: Peng Fan Signed-off-by: Peng Fan --- diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index d0590fd137..50edeb4b5b 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -818,6 +818,9 @@ static int fecmxc_recv(struct udevice *dev, int flags, uchar **packetp) return -ENOMEM; } + if (!(readl(&fec->eth->ecntrl) & FEC_ECNTRL_ETHER_EN)) + return 0; + /* Check if any critical events have happened */ ievent = readl(&fec->eth->ievent); writel(ievent, &fec->eth->ievent);