]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
ARM: dts: at91: fix the GPIO polarity for onewire
authorEugen Hristev <eugen.hristev@microchip.com>
Wed, 23 Jun 2021 13:13:35 +0000 (16:13 +0300)
committerEugen Hristev <eugen.hristev@microchip.com>
Tue, 6 Jul 2021 12:17:10 +0000 (15:17 +0300)
The GPIO polarity for onewire must be GPIO_ACTIVE_HIGH.
On previous versions this used to work as it looks like the right flag values
are being passed since :
https://lists.denx.de/pipermail/u-boot/2020-April/407195.html

And that series broke the old functionality for onewire nodes.
Some boards had the correct value for the polarity, but it wasn't clear
so I replaced it with the right macro for the flag, instead of an empty value.

Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
arch/arm/dts/at91-sama5d27_som1_ek.dts
arch/arm/dts/at91-sama5d27_wlsom1_ek.dts
arch/arm/dts/at91-sama5d2_ptc_ek.dts
arch/arm/dts/at91-sama5d2_xplained.dts
arch/arm/dts/at91-sama5d3_xplained.dts
arch/arm/dts/at91-sama5d4_xplained.dts
arch/arm/dts/sam9x60ek.dts

index 4cd6db66fe543f2856a9b47491f053d8ae3d2afc..ee851a1befcd28adea445324baa6a965be698738 100644 (file)
@@ -43,6 +43,7 @@
  *     OTHER DEALINGS IN THE SOFTWARE.
  */
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include "sama5d27_som1.dtsi"
 
 / {
@@ -55,7 +56,7 @@
        };
 
        onewire_tm: onewire {
-               gpios = <&pioA 17 0>;
+               gpios = <&pioA 17 GPIO_ACTIVE_HIGH>;
                pinctrl-names = "default";
                pinctrl-0 = <&pinctrl_onewire_tm_default>;
                status = "okay";
index ab23f5c209d61091f5fe1da65b6722a552f4919a..f3f6942143d3f1e0d29174daf6f515a82dfd229d 100644 (file)
@@ -7,6 +7,7 @@
  * Author: Nicolas Ferre <nicolas.ferre@microcihp.com>
  */
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include "sama5d27_wlsom1.dtsi"
 
 / {
@@ -18,7 +19,7 @@
        };
 
        onewire_tm: onewire {
-               gpios = <&pioA PIN_PC9 0>;
+               gpios = <&pioA PIN_PC9 GPIO_ACTIVE_HIGH>;
                pinctrl-names = "default";
                pinctrl-0 = <&pinctrl_onewire_tm_default>;
                status = "okay";
index 068a117585f4bb5dce208cb7b924504ecd810063..cd3711a02a5b8a4a175cda2c855505e3271cfe0c 100644 (file)
@@ -57,7 +57,7 @@
        };
 
        onewire_tm: onewire {
-               gpios = <&pioA PIN_PB31 0>;
+               gpios = <&pioA PIN_PB31 GPIO_ACTIVE_HIGH>;
                pinctrl-names = "default";
                pinctrl-0 = <&pinctrl_onewire_tm_default>;
                status = "okay";
index 7f0d1696ba3eccf6b72db0e6b460998502433235..b733c4d4ceeb60c264a61392a169f6331e57d377 100644 (file)
@@ -1,4 +1,5 @@
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include "sama5d2.dtsi"
 #include "sama5d2-pinfunc.h"
 
@@ -12,7 +13,7 @@
        };
 
        onewire_tm: onewire {
-               gpios = <&pioA PIN_PB0 0>;
+               gpios = <&pioA PIN_PB0 GPIO_ACTIVE_HIGH>;
                pinctrl-names = "default";
                pinctrl-0 = <&pinctrl_onewire_tm_default>;
                status = "okay";
index 20fba5f067cea98f4b8f80d50d633b932f9ee8d8..fc508002a72e9b12dc197869bb3236bca1cdd894 100644 (file)
@@ -37,7 +37,7 @@
        };
 
        onewire_tm: onewire {
-               gpios = <&pioE 23 GPIO_ACTIVE_LOW>;
+               gpios = <&pioE 23 GPIO_ACTIVE_HIGH>;
                pinctrl-names = "default";
                pinctrl-0 = <&pinctrl_onewire_tm_default>;
                status = "okay";
index 7da5086865b84cb5bbbc1c1f422b00852cf029db..74959253dc8003de5c5e8163eb235d5d32f2e1f5 100644 (file)
@@ -59,7 +59,7 @@
        };
 
        onewire_tm: onewire {
-               gpios = <&pioE 15 GPIO_ACTIVE_LOW>;
+               gpios = <&pioE 15 GPIO_ACTIVE_HIGH>;
                pinctrl-names = "default";
                pinctrl-0 = <&pinctrl_onewire_tm_default>;
                status = "okay";
index 96914b3ea2ca3ae39a405acc94c39716b6f266ab..77edd593b41658fa1ec4cac30e072c18a01e5c59 100644 (file)
@@ -29,7 +29,7 @@
        };
 
        onewire_tm: onewire {
-               gpios = <&pioD 14 0>;
+               gpios = <&pioD 14 GPIO_ACTIVE_HIGH>;
                pinctrl-names = "default";
                pinctrl-0 = <&pinctrl_onewire_tm_default>;
                status = "okay";