From ddcfb9ede8da45ebbdb1c4facf07b0f0b735373f Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Sat, 23 Dec 2023 02:17:33 +0100 Subject: [PATCH] lib: smbios: remove redundant next_header() next_header() and get_next_header() only differ in how the const attribute is used. One function taking a const parameter and returning a non-const is good enough. Signed-off-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- lib/smbios-parser.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/smbios-parser.c b/lib/smbios-parser.c index e1180efae1..ac9a367a87 100644 --- a/lib/smbios-parser.c +++ b/lib/smbios-parser.c @@ -39,14 +39,7 @@ static u8 *find_next_header(u8 *pos) return pos; } -static struct smbios_header *get_next_header(struct smbios_header *curr) -{ - u8 *pos = ((u8 *)curr) + curr->length; - - return (struct smbios_header *)find_next_header(pos); -} - -static const struct smbios_header *next_header(const struct smbios_header *curr) +static struct smbios_header *get_next_header(const struct smbios_header *curr) { u8 *pos = ((u8 *)curr) + curr->length; @@ -62,7 +55,7 @@ const struct smbios_header *smbios_header(const struct smbios_entry *entry, int if (header->type == type) return header; - header = next_header(header); + header = get_next_header(header); } return NULL; -- 2.39.5