From: Nishanth Menon Date: Fri, 14 Apr 2023 22:06:44 +0000 (-0500) Subject: net: phy: Drop phy_interface_is_sgmii X-Git-Url: http://git.dujemihanovic.xyz/html/index.html?a=commitdiff_plain;h=f1a63f7181784e6de92a9759e7d61e5ce9c00582;p=u-boot.git net: phy: Drop phy_interface_is_sgmii Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes with Linux") reordered the enum definitions. This caused the range of enums that this api was checking to go bad. There aren't anymore users of phy_interface_is_sgmii, so, just drop it. Also the protocols are so very different that it makes no sense to provide a helper wrapper in the hope of reuse for phy drivers. Reported-by: Tom Rini Suggested-by: Marek Vasut Suggested-by: Marek Behún Link: https://lore.kernel.org/all/20230414103852.38705065@dellmb/ Signed-off-by: Nishanth Menon Reviewed-by: Ramon Fried --- diff --git a/include/phy.h b/include/phy.h index a837fed723..cb87d1d4fc 100644 --- a/include/phy.h +++ b/include/phy.h @@ -365,18 +365,6 @@ static inline bool phy_interface_is_rgmii(struct phy_device *phydev) phydev->interface <= PHY_INTERFACE_MODE_RGMII_TXID; } -/** - * phy_interface_is_sgmii - Convenience function for testing if a PHY interface - * is SGMII (all variants) - * @phydev: the phy_device struct - * @return: true if MII bus is SGMII or false if it is not - */ -static inline bool phy_interface_is_sgmii(struct phy_device *phydev) -{ - return phydev->interface >= PHY_INTERFACE_MODE_SGMII && - phydev->interface <= PHY_INTERFACE_MODE_QSGMII; -} - bool phy_interface_is_ncsi(void); /* PHY UIDs for various PHYs that are referenced in external code */