From: Alexander Sverdlin Date: Wed, 1 May 2024 18:53:04 +0000 (+0200) Subject: mmc: sdhci: Correct ADMA_DESC_LEN to 12 X-Git-Url: http://git.dujemihanovic.xyz/html/index.html?a=commitdiff_plain;h=c92d48f8b2909d08584f17612a23d959467f14b8;p=u-boot.git mmc: sdhci: Correct ADMA_DESC_LEN to 12 Commit 37cb626da25d0d ("mmc: sdhci: Add Support for ADMA2") introduced ADMA_DESC_LEN == 16 (64 bit case), but it was never used before commit 74755c1fed1b0 ("mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops"). "sizeof(struct sdhci_adma_desc)" (== 12 for 64bit case) was used instead. Confusion probably originates from Linux commit 685e444bbaa0 ("mmc: sdhci: Add ADMA2 64-bit addressing support for V4 mode"), but the latter "V4 mode" was never ported to U-Boot. Fixes: 74755c1fed1b0 ("mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops") Signed-off-by: Alexander Sverdlin Tested-by: Jonathan Humphreys Tested-by: Judith Mendez --- diff --git a/include/sdhci.h b/include/sdhci.h index 78ef0d1c08..31a49ca6a2 100644 --- a/include/sdhci.h +++ b/include/sdhci.h @@ -301,7 +301,7 @@ struct sdhci_ops { #define ADMA_MAX_LEN 65532 #ifdef CONFIG_MMC_SDHCI_ADMA_64BIT -#define ADMA_DESC_LEN 16 +#define ADMA_DESC_LEN 12 #else #define ADMA_DESC_LEN 8 #endif