From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Date: Thu, 10 Nov 2022 11:19:30 +0000 (+0100)
Subject: cmd: remove superfluous if in eficonfig_edit_boot_option
X-Git-Url: http://git.dujemihanovic.xyz/html/index.html?a=commitdiff_plain;h=3d595ac5f5cbcf4db793caee035ab28304f41457;p=u-boot.git

cmd: remove superfluous if in eficonfig_edit_boot_option

Goto for an immediately succeeding label is superfluous.

Fixes: 87d791423ac6 ("eficonfig: menu-driven addition of UEFI boot option")
Addresses-Coverity: 376202 ("Identical code for different branches")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---

diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c
index 2595dd9563..0dc6e7b01e 100644
--- a/cmd/eficonfig.c
+++ b/cmd/eficonfig.c
@@ -1527,8 +1527,6 @@ static efi_status_t eficonfig_edit_boot_option(u16 *varname, struct eficonfig_bo
 	}
 
 	ret = eficonfig_set_boot_option(varname, final_dp, final_dp_size, bo->description, tmp);
-	if (ret != EFI_SUCCESS)
-		goto out;
 out:
 	free(tmp);
 	free(bo->optional_data);